Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assembly view #65

Merged
merged 5 commits into from
Dec 30, 2024
Merged

add assembly view #65

merged 5 commits into from
Dec 30, 2024

Conversation

techmannih
Copy link
Contributor

@techmannih techmannih commented Dec 29, 2024

add assembly view
/claim #62
fix #62

20241229203935.mp4

Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
runframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 4:23am

Copy link

@ShiboSoftwareDev ShiboSoftwareDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix typecheck

@techmannih
Copy link
Contributor Author

techmannih commented Dec 29, 2024

@ShiboSoftwareDev correct, but I think without publish can't we added assembly-viewer
image

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work but should be part of dropdown, we don't have enough header space

@seveibar
Copy link
Contributor

@techmannih the assembly viewer is now published

@techmannih
Copy link
Contributor Author

@seveibar
image

Copy link

@ShiboSoftwareDev ShiboSoftwareDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seveibar the text looks weird but I guess this is it's own issue
image

@seveibar
Copy link
Contributor

@techmannih you can resolve merge conflicts following this guide https://github.com/tscircuit/handbook/blob/main/guides/basics/learn-git.md#resolving-bunlockb-conflicts

@techmannih
Copy link
Contributor Author

@seveibar done

@seveibar seveibar merged commit be2f019 into tscircuit:main Dec 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add assembly view (and tab)
3 participants