Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow for monitoring bundle size of landing page and "main app" #453

Open
seveibar opened this issue Dec 31, 2024 · 0 comments
Open

Comments

@seveibar
Copy link
Contributor

There are two vite entrypoints, one for the "main app" and one for the landing page.

We want to monitor these bundle sizes to make sure they don't become excessive.

Unlike tscircuit/core, these have to monitored somewhat continuously on every PR because an accidental import in the wrong file can cause the bundle size to dramatically increase

An alternative to monitoring so much is to change large imports like Typescript so that they load directly in a <script /> tag, this makes it easier to control for the bundle size since there are basically no large imports. You then avoid placing the typescript <script /> tag on the landing.html page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant