Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Get Started button out of bounds in mobiles #550

Closed
wants to merge 1 commit into from
Closed

fix: Get Started button out of bounds in mobiles #550

wants to merge 1 commit into from

Conversation

kom-senapati
Copy link
Contributor

image

/claim #549
Closes #549

@algora-pbc algora-pbc bot mentioned this pull request Jan 13, 2025
Closed
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 16, 2025
@seveibar
Copy link
Contributor

Doesn't seem to fix issue

image

@kom-senapati
Copy link
Contributor Author

image

Looks good to me in mobile

@seveibar
Copy link
Contributor

ok the only way to settle this is with a playwright test

@github-actions github-actions bot removed the stale label Jan 17, 2025
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 19, 2025
@github-actions GitHub Actions
Copy link

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions bot closed this Jan 21, 2025
@Anshgrover23 Anshgrover23 reopened this Jan 21, 2025
Anshgrover23
Anshgrover23 requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Anshgrover23 Anshgrover23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kom-senapati this pr is closed by stalebot, i have reopened for you when you are ready with the playwright tests, just marked a ready for review

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anshgrover23 Anshgrover23 Anshgrover23 requested changes

@seveibar seveibar Awaiting requested review from seveibar seveibar is a code owner

@imrishabh18 imrishabh18 Awaiting requested review from imrishabh18 imrishabh18 is a code owner

Assignees
No one assigned
Labels
🙋 Bounty claim stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slight gap in right side of screen in mobile view
3 participants
@kom-senapati @seveibar @Anshgrover23