-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow new options to k-way stats #1648
Comments
Would a solution be to use flags directly in the low-level Python C API? I.e., we export the flags values from _tskit, and pass an |
Oh, yes, that's the right way to do it. =) (I think - we'll have to try it to see!) |
OK, let's do it as a follow up to #1623 - no point in complicating that with a bunch of infrastructure changes. |
LMK if you want me to have a go at it. |
OK if we push this one out to the 0.4.1 release @petrelharp? We're nearly there for 0.4.0 and it would be good to get it shipped. |
Sure - I've got no bandwidth. |
Over in #1623 we've added a new option,
centre
to the C k-way stats method because we wanted to add it togenetic_relatedness
, and I couldn't see a way to add it to onlygenetic_relatedness
. The option does nothing for other methods. This seems unfortunate, and led to having to do some hackey stuff in Fst, which calls both one- and k-way methods. We should figure out how to do this better, at least before we want to add any more arguments that affect only one method.The text was updated successfully, but these errors were encountered: