Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Ruff to replace flake8, isort, PyLint and Black #241

Open
terop opened this issue Feb 17, 2024 · 3 comments · May be fixed by #258
Open

Consider using Ruff to replace flake8, isort, PyLint and Black #241

terop opened this issue Feb 17, 2024 · 3 comments · May be fixed by #258

Comments

@terop
Copy link
Contributor

terop commented Feb 17, 2024

Ruff is a "multi-purpose" tool for Python linting and code-formatting which can replace the current tools apart from mypy. This would improve the developer experience as there would be only two tools for linting and formatting instead of four that there is now. Ruff is also very fast which makes it pleasant to use.

There are some downsides too: Ruff does not yet have all the rules which flake8 and PyLint includes. Also it is still under somewhat active development meaning that previously working code might be "broken" with a newer Ruff version. This problem can of course be avoided by using a pinned version which probably should be done anyway.

Would this idea make sense?

@terop terop added the bug label Feb 17, 2024
@terop
Copy link
Contributor Author

terop commented Feb 17, 2024

This is not a real bug but an enhancement / idea but I couldn't figure out how to change the label to something else than "bug". Please feel free to change the label to something more appropriate.

@ttu ttu added enhancement and removed bug labels Feb 19, 2024
@ttu
Copy link
Owner

ttu commented Feb 19, 2024

It seems that Ruff is already quite production-ready and is used by many large projects, so I agree that we should give it a try.

Since it is under very active development, we should indeed pin the version we use, as you suggested.

Would you like to try it and share your findings here?

@terop
Copy link
Contributor Author

terop commented Feb 19, 2024

Sure, at some point.

@terop terop linked a pull request Nov 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants