New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this package is broken - if no path was found then it should return next() so it moves along to next middleware and eventually 404 handler #13

Open

niftylettuce opened this issue Sep 11, 2017 · 3 comments

niftylettuce commented Sep 11, 2017

No description provided.

niftylettuce changed the title ~~this package is broken - if no path was found then it should return next() so it moves along to next route and 404 handler~~ this package is broken - if no path was found then it should return next() so it moves along to next middleware and eventually 404 handler

Author

niftylettuce commented Sep 11, 2017

aka its missing core defer usage

Author

niftylettuce commented Sep 11, 2017

see https://github.com/ohomer/koa-better-static/blob/master/index.js#L71

Owner

tunnckoCore commented Sep 11, 2017

Hm. It sets 404 when error.

Would you mind PR with fix and test case?

tunnckoCore mentioned this issue

It cant be used with router middleware? #29

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment