-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docker]: add image build test to GitHub Actions #295
Comments
This comment was marked as resolved.
This comment was marked as resolved.
Here is where I currently stand:
It seems the current base image used in Dockerfile (docker/Dockerfile : rust:bookworm) that the official Rust image does not support Windows as host machine.
If you’d like, I can start opening a PR for this topic. I will likely need help from Mac users to find the right setup for the GitHub Actions workflow. |
Thank you for you initial work on this issue!
That's good, having. at least one working OS is a good start 😅 Regarding MacOS
From Docker Mac System requirements documentation it looks like that you need to install Rosetta, There is also a mention in the known issue section:
Regarding WindowsUnfortunately I'm not able to to help here 😭 Though regarding both MacOS and WindowsMaybe there is an action that can help setup a docker environment that might take care of some issue you experiencing. In either case if testing MacOS and Windows compose turns into a living hell we can avoid it and go ahead with just a unix job.
Probably is better. Since you have tackled with some code done a PR is better place than an issue to discuss it. |
Followup of #276 (comment)
Basically it would be great if we can add a new workflow to test that the docker image is building correctly across unix-like and windows platforms
@spacecodeur, if you are still interested, could you please drop a comment so I can assign the issue to you?
The text was updated successfully, but these errors were encountered: