Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker]: add image build test to GitHub Actions #295

Open
marcalexiei opened this issue Jan 12, 2025 · 4 comments · May be fixed by #332
Open

[Docker]: add image build test to GitHub Actions #295

marcalexiei opened this issue Jan 12, 2025 · 4 comments · May be fixed by #332
Assignees
Labels

Comments

@marcalexiei
Copy link
Member

marcalexiei commented Jan 12, 2025

Followup of #276 (comment)

Basically it would be great if we can add a new workflow to test that the docker image is building correctly across unix-like and windows platforms

@spacecodeur, if you are still interested, could you please drop a comment so I can assign the issue to you?

@spacecodeur

This comment was marked as resolved.

@spacecodeur
Copy link
Contributor

Here is where I currently stand:

  • Linux job: It works very well.

  • Mac OS job:

    • I managed to make it work, but the result is not very satisfying because it only works on macOS version 13. I am using the Colima container runtime, which adds a significant layer to the process and thus impacts the build time on GitHub Actions.
    • I haven’t yet succeeded in getting the Tuono image build to work on the latest macOS version (14), mainly due to the architecture shift to ARM.
  • Windows job:

    • Without using WSL, Here is the error I am encountering:

image

It seems the current base image used in Dockerfile (docker/Dockerfile : rust:bookworm) that the official Rust image does not support Windows as host machine.

  • I’ve looked into using WSL and how to install it through a GitHub Actions workflow, but I haven’t had success so far. I’ll try again during the week.

If you’d like, I can start opening a PR for this topic. I will likely need help from Mac users to find the right setup for the GitHub Actions workflow.

@marcalexiei
Copy link
Member Author

Thank you for you initial work on this issue!

Linux job: It works very well.

That's good, having. at least one working OS is a good start 😅


Regarding MacOS

I haven’t yet succeeded in getting the Tuono image build to work on the latest macOS version (14), mainly due to the architecture shift to ARM.

From Docker Mac System requirements documentation it looks like that you need to install Rosetta,
hence there are some problems with the ARM architecture.

There is also a mention in the known issue section:
https://docs.docker.com/desktop/troubleshoot-and-support/troubleshoot/known-issues/

Some command line tools do not work when Rosetta 2 is not installed.
[...]

Regarding Windows

Unfortunately I'm not able to to help here 😭


Though regarding both MacOS and Windows

Maybe there is an action that can help setup a docker environment that might take care of some issue you experiencing.
E.g.: https://github.com/adambirds/docker-compose-action

In either case if testing MacOS and Windows compose turns into a living hell we can avoid it and go ahead with just a unix job.


If you’d like, I can start opening a PR for this topic. I will likely need help from Mac users to find the right setup for the GitHub Actions workflow.

Probably is better. Since you have tackled with some code done a PR is better place than an issue to discuss it.

@spacecodeur spacecodeur linked a pull request Jan 13, 2025 that will close this issue
@Valerioageno Valerioageno moved this from Ready to In progress in Road to V1 Jan 19, 2025
@Valerioageno

This comment has been minimized.

@Valerioageno Valerioageno linked a pull request Jan 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants