-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CLI check that all the tuono versions in the projects are aligned #406
Comments
Can I look into this one? |
Yes,
The warning is not blocking, Solution 1
Solution 2Add Solution 3Starting setup a I would consider to set this option to // tuono.config.ts
import type { TuonoConfig } from 'tuono/config'
const config: TuonoConfig = {
// ...
check: {
versionMismatch: true,
}
}
export default config Additional features related to this approach:
I personally like solution 3 because gives us more space for additional checks in the future. Let me know what do you think about this! |
Hey guys! I'd descope this task since next in line for development for the CLI are:
|
I moved this issue and all the relevant content inside a "Add a CLI check that all the tuono versions in the projects are aligned" draft item of V1 project |
I think we should add some kind of remedy for this, especially since old CLI versions don't work in new tuono projects. Demo repro (from 'apps/documentation`):
This gives an error (docs currently on 0.17.6)
Maybe we should do this after we've finished writing the rest of the docs? |
Yeah, when there are breaking changes in the CLI/server contract, it is very easy that a version mismatch breaks the build. |
Within a tuono app, there are plenty of reference to the tuono:
Cargo.toml
package.json
In order to prevent wrong mismatch between packages/CLI versions, we could add warning on
tuono build
andtuono dev
command to highlight such a mismatch.Additional context
The text was updated successfully, but these errors were encountered: