Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Link leading to other documentation pages aren't opened in a new tab using cmd + click #531

Closed
marcalexiei opened this issue Feb 7, 2025 · 1 comment · Fixed by #534
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@marcalexiei
Copy link
Member

Description

Refer to the title

Expected behaviour

I can open links in a new tab when using cmd + click

How to reproduce

  1. Go to https://tuono.dev/documentation/routing/link-and-navigation
  2. (Cmd / ctrl) + Click on a link leading to a page of the documentation site
    • "useRouter API reference page"
    • "Link component API reference page".

Screenshots

No response

System Info

Not applicable

System info (Rust)

Not applicable

Additional context

No response

@marcalexiei marcalexiei added bug Something isn't working documentation Improvements or additions to documentation labels Feb 7, 2025
@jacobhq
Copy link
Member

jacobhq commented Feb 8, 2025

I've recently worked on the docs links, and I think the issue is that for internal links, they don't use the tuono link component, they use e.preventDefault() and router.push. I'm happy to take a look at this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants