fix: update link component to allow modifier+click to properly work, and write tests #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test in docs, replace tuono version in package.json with 2025-02-08.15-46-52.mp4 |
Valerioageno
reviewed
Feb 8, 2025
Agreed, I'm happy to do that! |
marcalexiei
requested changes
Feb 9, 2025
There was a problem hiding this comment.
Now all links now open in a new tab, with or without modifier key pressed.
This behaviour is caused by the code of MdxLink:
This issue was hidden by the event.preventDefault always executed on Link click event handler.
The target="_blank" should be removed from MdxLink component when rendering internal links.
github-actions
bot
added
the
documentation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jacobhq
changed the title
marcalexiei
reviewed
Feb 9, 2025
marcalexiei
reviewed
Feb 9, 2025
marcalexiei
approved these changes
Feb 9, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related issue
Fixes #531
Overview
This PR makes the link fallback to default
abehaviour when a modifier key is being pressed.