Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Running tuono dev panics on version 0.17.7 #539

Open
avj2352 opened this issue Feb 9, 2025 · 6 comments
Open

[Bug]: Running tuono dev panics on version 0.17.7 #539

avj2352 opened this issue Feb 9, 2025 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@avj2352
Copy link
Contributor

avj2352 commented Feb 9, 2025

Description

Recently updated my tuono cli to 0.17.7

When I run tuono dev I get this error

<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")

After this, going back to previous version also doesn't solve this error.

Expected behaviour

  • I install cargo install tuono
  • I run tuono --version
    • It shows tuono 0.17.7
  • I update my package.json "tuono": "0.17.7"
  • I update my cargo.toml tuono_lib = "=0.17.7"
  • I clear all build directories - .tuono, target, node_modules, cargo.lock and package-lock.json
  • I then run npm i
  • I then run tuono dev

It should work and serve the files.

How to reproduce

  • I install cargo install tuono
  • I run tuono --version
    • It shows tuono 0.17.6
  • I update my package.json "tuono": "0.17.6"
  • I update my cargo.toml tuono_lib = "=0.17.6"
  • I clear all build directories - .tuono, target, node_modules, cargo.lock and package-lock.json
  • I then run npm i
  • I then run tuono dev

I get this error instead. Same error occurs with 0.17.7

<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
<unknown>:1928550: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /Users/pramodjingade/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tuono_lib-0.17.6/src/ssr.rs:54:10:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug"

Screenshots

Image

System Info

System:
    OS: macOS 15.3
    CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
    Memory: 190.44 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.9.0 - /usr/local/bin/node
    npm: 10.8.3 - /usr/local/bin/npm
    bun: 1.0.9 - /usr/local/bin/bun
  Browsers:
    Chrome: 113.0.5672.126
    Safari: 18.3
  npmPackages:
    tuono: 0.17.6 => 0.17.6

System info (Rust)

rustc --version && cargo --version && tuono --version
rustc 1.84.0 (9fc6b4312 2025-01-07)
cargo 1.84.0 (66221abde 2024-11-19)
tuono 0.17.6

Additional context

No additional context

@avj2352 avj2352 added the bug Something isn't working label Feb 9, 2025
@avj2352
Copy link
Contributor Author

avj2352 commented Feb 9, 2025

Hey Team, new update

I was able to resolve the error.

  • I did a tuono new temp_app (using [email protected])
  • I copied all my package.json and src folders into the new temp_app
  • I was able to run the app using tuono dev
    🤷🏻‍♂️

@Valerioageno
Copy link
Member

Can you share the Regex you were using?

@Valerioageno Valerioageno self-assigned this Feb 9, 2025
@voldtman
Copy link

This issue still persists even on the latest build with the prod mode for me, especially when using libraries that use unicode property escape regexes, like https://www.npmjs.com/package/linkifyjs. @Valerioageno

@Valerioageno
Copy link
Member

Can you share the error you get by using that library?

@Valerioageno Valerioageno reopened this Feb 20, 2025
@voldtman
Copy link

voldtman commented Feb 21, 2025

I immediately got this exact same error as OP's when starting the prod server and accessing the app.

<unknown>:871115: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /home/agam/proj/tuonocrates/tuono_lib/src/ssr.rs:41:23:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
<unknown>:871115: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /home/agam/proj/tuonocrates/tuono_lib/src/ssr.rs:41:23:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")
<unknown>:871115: Uncaught SyntaxError: Invalid regular expression: /\p{Emoji}/u: Invalid property name
thread 'tokio-runtime-worker' panicked at /home/agam/proj/tuonocrates/tuono_lib/src/ssr.rs:41:23:
called `Result::unwrap()` on an `Err` value: InvalidJs("Execute your script with d8 to debug")

It seems to only occur specifically when using any \p{...} (unicode property escapes) regex though, patching and removing the regex on the package solves the issue, at least for now.

diff --git a/dist/linkify.cjs.d.ts b/dist/linkify.cjs.d.ts
index 4bf3295a8bc65a0b934949350c4219eae88989f3..b03ff3bc8aa40b528f43b725aa0394fe17b7f67c 100644
--- a/dist/linkify.cjs.d.ts
+++ b/dist/linkify.cjs.d.ts
@@ -469,8 +469,8 @@ export var regexp: Readonly<{
     __proto__: any;
     ASCII_LETTER: RegExp;
     LETTER: RegExp;
-    EMOJI: RegExp;
-    EMOJI_VARIATION: RegExp;
+    // EMOJI: RegExp;
+    // EMOJI_VARIATION: RegExp;
     DIGIT: RegExp;
     SPACE: RegExp;
 }>;
@@ -622,7 +622,7 @@ declare var tk: Readonly<{
     SLASH: "SLASH";
     TILDE: "TILDE";
     UNDERSCORE: "UNDERSCORE";
-    EMOJI: "EMOJI";
+    // EMOJI: "EMOJI";
     SYM: "SYM";
 }>;
 declare var groups: Collections<string>;
diff --git a/dist/linkify.cjs.js b/dist/linkify.cjs.js
index 1b8b04e748ae26877d60cb1824d2abeaf276da92..2be0770b8512a4c82b5d03ad28c22ccffbef98b9 100644
--- a/dist/linkify.cjs.js
+++ b/dist/linkify.cjs.js
@@ -43,7 +43,7 @@ const alpha = 'alpha';
 const asciinumeric = 'asciinumeric';
 const alphanumeric = 'alphanumeric';
 const domain = 'domain';
-const emoji = 'emoji';
+// const emoji = 'emoji';
 const scheme = 'scheme';
 const slashscheme = 'slashscheme';
 const whitespace = 'whitespace';
@@ -85,9 +85,9 @@ function addToGroups(t, flags, groups) {
   if (flags[alphanumeric]) {
     flags[domain] = true;
   }
-  if (flags[emoji]) {
-    flags[domain] = true;
-  }
+  // if (flags[emoji]) {
+  //   flags[domain] = true;
+  // }
   for (const k in flags) {
     const group = registerGroup(k, groups);
     if (group.indexOf(t) < 0) {
@@ -438,7 +438,7 @@ const TILDE = 'TILDE'; // ~
 const UNDERSCORE = 'UNDERSCORE'; // _
 
 // Emoji symbol
-const EMOJI$1 = 'EMOJI';
+// const EMOJI$1 = 'EMOJI';
 
 // Default token - anything that is not one of the above
 const SYM = 'SYM';
@@ -498,15 +498,15 @@ var tk = /*#__PURE__*/Object.freeze({
 	SLASH: SLASH,
 	TILDE: TILDE,
 	UNDERSCORE: UNDERSCORE,
-	EMOJI: EMOJI$1,
+	// EMOJI: EMOJI$1,
 	SYM: SYM
 });
 
 // Note that these two Unicode ones expand into a really big one with Babel
 const ASCII_LETTER = /[a-z]/;
 const LETTER = /\p{L}/u; // Any Unicode character with letter data type
-const EMOJI = /\p{Emoji}/u; // Any Unicode emoji character
-const EMOJI_VARIATION$1 = /\ufe0f/;
+// const EMOJI = /\p{Emoji}/u; // Any Unicode emoji character
+// const EMOJI_VARIATION$1 = /\ufe0f/;
 const DIGIT = /\d/;
 const SPACE = /\s/;
 
@@ -514,8 +514,8 @@ var regexp = /*#__PURE__*/Object.freeze({
 	__proto__: null,
 	ASCII_LETTER: ASCII_LETTER,
 	LETTER: LETTER,
-	EMOJI: EMOJI,
-	EMOJI_VARIATION: EMOJI_VARIATION$1,
+	// EMOJI: EMOJI,
+	// EMOJI_VARIATION: EMOJI_VARIATION$1,
 	DIGIT: DIGIT,
 	SPACE: SPACE
 });
@@ -526,8 +526,8 @@ var regexp = /*#__PURE__*/Object.freeze({
 */
 const CR = '\r'; // carriage-return character
 const LF = '\n'; // line-feed character
-const EMOJI_VARIATION = '\ufe0f'; // Variation selector, follows heart and others
-const EMOJI_JOINER = '\u200d'; // zero-width joiner
+// const EMOJI_VARIATION = '\ufe0f'; // Variation selector, follows heart and others
+// const EMOJI_JOINER = '\u200d'; // zero-width joiner
 const OBJECT_REPLACEMENT = '\ufffc'; // whitespace placeholder that sometimes appears in rich text editors
 
 let tlds = null,
@@ -664,17 +664,17 @@ function init$2(customSchemes = []) {
 
   // Emoji tokens. They are not grouped by the scanner except in cases where a
   // zero-width joiner is present
-  const Emoji = tr(Start, EMOJI, EMOJI$1, {
-    [emoji]: true
-  });
-  tt(Emoji, '#'); // no transition, emoji regex seems to match #
-  tr(Emoji, EMOJI, Emoji);
-  tt(Emoji, EMOJI_VARIATION, Emoji);
-  // tt(Start, EMOJI_VARIATION, Emoji); // This one is sketchy
-
-  const EmojiJoiner = tt(Emoji, EMOJI_JOINER);
-  tt(EmojiJoiner, '#');
-  tr(EmojiJoiner, EMOJI, Emoji);
+  // const Emoji = tr(Start, EMOJI, EMOJI$1, {
+  //   [emoji]: true
+  // });
+  // tt(Emoji, '#'); // no transition, emoji regex seems to match #
+  // tr(Emoji, EMOJI, Emoji);
+  // tt(Emoji, EMOJI_VARIATION, Emoji);
+  // // tt(Start, EMOJI_VARIATION, Emoji); // This one is sketchy
+
+  // const EmojiJoiner = tt(Emoji, EMOJI_JOINER);
+  // tt(EmojiJoiner, '#');
+  // tr(EmojiJoiner, EMOJI, Emoji);
   // tt(EmojiJoiner, EMOJI_VARIATION, Emoji); // also sketchy
 
   // Generates states for top-level domains
diff --git a/dist/linkify.es.d.ts b/dist/linkify.es.d.ts
index d71f838dcf0c18b499803756b02330e6ab0c8f49..42a3536af2e278db926f7b92396f83f3c23be194 100644
--- a/dist/linkify.es.d.ts
+++ b/dist/linkify.es.d.ts
@@ -468,8 +468,8 @@ export var regexp: Readonly<{
     __proto__: any;
     ASCII_LETTER: RegExp;
     LETTER: RegExp;
-    EMOJI: RegExp;
-    EMOJI_VARIATION: RegExp;
+    // EMOJI: RegExp;
+    // EMOJI_VARIATION: RegExp;
     DIGIT: RegExp;
     SPACE: RegExp;
 }>;
@@ -621,7 +621,7 @@ declare var tk: Readonly<{
     SLASH: "SLASH";
     TILDE: "TILDE";
     UNDERSCORE: "UNDERSCORE";
-    EMOJI: "EMOJI";
+    // EMOJI: "EMOJI";
     SYM: "SYM";
 }>;
 declare var groups: Collections<string>;
diff --git a/dist/linkify.es.js b/dist/linkify.es.js
index c88d79f1e0a70f137e6bcdbabc716e00cabaaa11..4f2232f27a5fb6fd93d98bb2c0f85743157968db 100644
--- a/dist/linkify.es.js
+++ b/dist/linkify.es.js
@@ -39,7 +39,7 @@ const alpha = 'alpha';
 const asciinumeric = 'asciinumeric';
 const alphanumeric = 'alphanumeric';
 const domain = 'domain';
-const emoji = 'emoji';
+// const emoji = 'emoji';
 const scheme = 'scheme';
 const slashscheme = 'slashscheme';
 const whitespace = 'whitespace';
@@ -81,9 +81,9 @@ function addToGroups(t, flags, groups) {
   if (flags[alphanumeric]) {
     flags[domain] = true;
   }
-  if (flags[emoji]) {
-    flags[domain] = true;
-  }
+  // if (flags[emoji]) {
+  //   flags[domain] = true;
+  // }
   for (const k in flags) {
     const group = registerGroup(k, groups);
     if (group.indexOf(t) < 0) {
@@ -434,7 +434,7 @@ const TILDE = 'TILDE'; // ~
 const UNDERSCORE = 'UNDERSCORE'; // _
 
 // Emoji symbol
-const EMOJI$1 = 'EMOJI';
+// const EMOJI$1 = 'EMOJI';
 
 // Default token - anything that is not one of the above
 const SYM = 'SYM';
@@ -494,15 +494,15 @@ var tk = /*#__PURE__*/Object.freeze({
 	SLASH: SLASH,
 	TILDE: TILDE,
 	UNDERSCORE: UNDERSCORE,
-	EMOJI: EMOJI$1,
+	// EMOJI: EMOJI$1,
 	SYM: SYM
 });
 
 // Note that these two Unicode ones expand into a really big one with Babel
 const ASCII_LETTER = /[a-z]/;
 const LETTER = /\p{L}/u; // Any Unicode character with letter data type
-const EMOJI = /\p{Emoji}/u; // Any Unicode emoji character
-const EMOJI_VARIATION$1 = /\ufe0f/;
+// const EMOJI = /\p{Emoji}/u; // Any Unicode emoji character
+// const EMOJI_VARIATION$1 = /\ufe0f/;
 const DIGIT = /\d/;
 const SPACE = /\s/;
 
@@ -510,8 +510,8 @@ var regexp = /*#__PURE__*/Object.freeze({
 	__proto__: null,
 	ASCII_LETTER: ASCII_LETTER,
 	LETTER: LETTER,
-	EMOJI: EMOJI,
-	EMOJI_VARIATION: EMOJI_VARIATION$1,
+	// EMOJI: EMOJI,
+	// EMOJI_VARIATION: EMOJI_VARIATION$1,
 	DIGIT: DIGIT,
 	SPACE: SPACE
 });
@@ -522,8 +522,8 @@ var regexp = /*#__PURE__*/Object.freeze({
 */
 const CR = '\r'; // carriage-return character
 const LF = '\n'; // line-feed character
-const EMOJI_VARIATION = '\ufe0f'; // Variation selector, follows heart and others
-const EMOJI_JOINER = '\u200d'; // zero-width joiner
+// const EMOJI_VARIATION = '\ufe0f'; // Variation selector, follows heart and others
+// const EMOJI_JOINER = '\u200d'; // zero-width joiner
 const OBJECT_REPLACEMENT = '\ufffc'; // whitespace placeholder that sometimes appears in rich text editors
 
 let tlds = null,
@@ -660,17 +660,17 @@ function init$2(customSchemes = []) {
 
   // Emoji tokens. They are not grouped by the scanner except in cases where a
   // zero-width joiner is present
-  const Emoji = tr(Start, EMOJI, EMOJI$1, {
-    [emoji]: true
-  });
-  tt(Emoji, '#'); // no transition, emoji regex seems to match #
-  tr(Emoji, EMOJI, Emoji);
-  tt(Emoji, EMOJI_VARIATION, Emoji);
-  // tt(Start, EMOJI_VARIATION, Emoji); // This one is sketchy
-
-  const EmojiJoiner = tt(Emoji, EMOJI_JOINER);
-  tt(EmojiJoiner, '#');
-  tr(EmojiJoiner, EMOJI, Emoji);
+  // const Emoji = tr(Start, EMOJI, EMOJI$1, {
+  //   [emoji]: true
+  // });
+  // tt(Emoji, '#'); // no transition, emoji regex seems to match #
+  // tr(Emoji, EMOJI, Emoji);
+  // tt(Emoji, EMOJI_VARIATION, Emoji);
+  // // tt(Start, EMOJI_VARIATION, Emoji); // This one is sketchy
+
+  // const EmojiJoiner = tt(Emoji, EMOJI_JOINER);
+  // tt(EmojiJoiner, '#');
+  // tr(EmojiJoiner, EMOJI, Emoji);
   // tt(EmojiJoiner, EMOJI_VARIATION, Emoji); // also sketchy
 
   // Generates states for top-level domains
diff --git a/dist/linkify.js b/dist/linkify.js
index 8fb1acbf8a4e0849b05cd152595f669ec7ce013c..16f96e69e2ed7ed5bf28a8eaecde7cb20aefa1c6 100644
--- a/dist/linkify.js
+++ b/dist/linkify.js
@@ -42,7 +42,7 @@ var linkify = (function (exports) {
 	const asciinumeric = 'asciinumeric';
 	const alphanumeric = 'alphanumeric';
 	const domain = 'domain';
-	const emoji = 'emoji';
+	// const emoji = 'emoji';
 	const scheme = 'scheme';
 	const slashscheme = 'slashscheme';
 	const whitespace = 'whitespace';
@@ -84,9 +84,9 @@ var linkify = (function (exports) {
 	  if (flags[alphanumeric]) {
 	    flags[domain] = true;
 	  }
-	  if (flags[emoji]) {
-	    flags[domain] = true;
-	  }
+	//   if (flags[emoji]) {
+	//     flags[domain] = true;
+	//   }
 	  for (const k in flags) {
 	    const group = registerGroup(k, groups);
 	    if (group.indexOf(t) < 0) {
@@ -437,7 +437,7 @@ var linkify = (function (exports) {
 	const UNDERSCORE = 'UNDERSCORE'; // _
 
 	// Emoji symbol
-	const EMOJI$1 = 'EMOJI';
+	// const EMOJI$1 = 'EMOJI';
 
 	// Default token - anything that is not one of the above
 	const SYM = 'SYM';
@@ -497,15 +497,15 @@ var linkify = (function (exports) {
 		SLASH: SLASH,
 		TILDE: TILDE,
 		UNDERSCORE: UNDERSCORE,
-		EMOJI: EMOJI$1,
+		// EMOJI: EMOJI$1,
 		SYM: SYM
 	});
 
 	// Note that these two Unicode ones expand into a really big one with Babel
 	const ASCII_LETTER = /[a-z]/;
 	const LETTER = /\p{L}/u; // Any Unicode character with letter data type
-	const EMOJI = /\p{Emoji}/u; // Any Unicode emoji character
-	const EMOJI_VARIATION$1 = /\ufe0f/;
+	// const EMOJI = /\p{Emoji}/u; // Any Unicode emoji character
+	// const EMOJI_VARIATION$1 = /\ufe0f/;
 	const DIGIT = /\d/;
 	const SPACE = /\s/;
 
@@ -513,8 +513,8 @@ var linkify = (function (exports) {
 		__proto__: null,
 		ASCII_LETTER: ASCII_LETTER,
 		LETTER: LETTER,
-		EMOJI: EMOJI,
-		EMOJI_VARIATION: EMOJI_VARIATION$1,
+		// EMOJI: EMOJI,
+		// EMOJI_VARIATION: EMOJI_VARIATION$1,
 		DIGIT: DIGIT,
 		SPACE: SPACE
 	});
@@ -525,8 +525,8 @@ var linkify = (function (exports) {
 	*/
 	const CR = '\r'; // carriage-return character
 	const LF = '\n'; // line-feed character
-	const EMOJI_VARIATION = '\ufe0f'; // Variation selector, follows heart and others
-	const EMOJI_JOINER = '\u200d'; // zero-width joiner
+	// const EMOJI_VARIATION = '\ufe0f'; // Variation selector, follows heart and others
+	// const EMOJI_JOINER = '\u200d'; // zero-width joiner
 	const OBJECT_REPLACEMENT = '\ufffc'; // whitespace placeholder that sometimes appears in rich text editors
 
 	let tlds = null,
@@ -663,17 +663,17 @@ var linkify = (function (exports) {
 
 	  // Emoji tokens. They are not grouped by the scanner except in cases where a
 	  // zero-width joiner is present
-	  const Emoji = tr(Start, EMOJI, EMOJI$1, {
-	    [emoji]: true
-	  });
-	  tt(Emoji, '#'); // no transition, emoji regex seems to match #
-	  tr(Emoji, EMOJI, Emoji);
-	  tt(Emoji, EMOJI_VARIATION, Emoji);
+	//   const Emoji = tr(Start, EMOJI, EMOJI$1, {
+	//     [emoji]: true
+	//   });
+	//   tt(Emoji, '#'); // no transition, emoji regex seems to match #
+	//   tr(Emoji, EMOJI, Emoji);
+	//   tt(Emoji, EMOJI_VARIATION, Emoji);
 	  // tt(Start, EMOJI_VARIATION, Emoji); // This one is sketchy
 
-	  const EmojiJoiner = tt(Emoji, EMOJI_JOINER);
-	  tt(EmojiJoiner, '#');
-	  tr(EmojiJoiner, EMOJI, Emoji);
+	//   const EmojiJoiner = tt(Emoji, EMOJI_JOINER);
+	//   tt(EmojiJoiner, '#');
+	//   tr(EmojiJoiner, EMOJI, Emoji);
 	  // tt(EmojiJoiner, EMOJI_VARIATION, Emoji); // also sketchy
 
 	  // Generates states for top-level domains

@Valerioageno
Copy link
Member

Thanks for sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants