Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: handler names are not snake case #562

Closed
Valerioageno opened this issue Feb 14, 2025 · 3 comments · Fixed by #565
Closed

[Bug]: handler names are not snake case #562

Valerioageno opened this issue Feb 14, 2025 · 3 comments · Fixed by #565
Assignees
@jacobhq
Labels
bug Something isn't working

Comments

@Valerioageno
Copy link
Member

Description

tuono__internal__route and tuono__internal__api are not snake case, hence rust-analyzer triggers an error.

Expected behaviour

The handlers name should be snake case to not trigger any error

How to reproduce

Open any tuono project with an IDE with rust-analyzer and you will see the diagnostic error below

Screenshots

Image

System Info

N/A

System info (Rust)

N/A

Additional context

No response
@Valerioageno Valerioageno added the bug Something isn't working label Feb 14, 2025
@jacobhq
Copy link
Member

jacobhq commented Feb 14, 2025

Happy to handle this if you like

@jacobhq jacobhq mentioned this issue Feb 15, 2025
Merged
1 task
@jacobhq
Copy link
Member

jacobhq commented Feb 15, 2025

Should I also rename get__tuono_internal_api and similar to get_tuono_internal_api, or leave those as is?

@Valerioageno
Copy link
Member Author

Yes! Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobhq jacobhq

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use snake_case for handler names jacobhq/tuono
2 participants
@jacobhq @Valerioageno