Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use snake_case for handler names #565

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

jacobhq
Copy link
Member

@jacobhq jacobhq commented Feb 15, 2025

Checklist

Related issue

Fixes #562

Overview

Remove the double underscore from handler names and use true snake_case.

@github-actions github-actions bot added the rust Requires rust knowledge label Feb 15, 2025
@jacobhq jacobhq marked this pull request as ready for review February 15, 2025 21:16
@Valerioageno
Copy link
Member

Looks good! Please update also the api one! 🙏🏽

@jacobhq
Copy link
Member Author

jacobhq commented Feb 16, 2025

Alright, should be all ready now, let me know what you think :)

Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks

@Valerioageno Valerioageno merged commit 06bc370 into tuono-labs:main Feb 16, 2025
20 checks passed
@jacobhq jacobhq deleted the jm-snake-case-handlers branch February 16, 2025 18:18
@jacobhq jacobhq restored the jm-snake-case-handlers branch February 22, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Requires rust knowledge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: handler names are not snake case
2 participants