Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add internal vite config #568

Merged
merged 11 commits into from
Feb 16, 2025
Merged

chore: add internal vite config #568

merged 11 commits into from
Feb 16, 2025

Conversation

marcalexiei
Copy link
Member

@marcalexiei marcalexiei commented Feb 15, 2025 •
edited
Loading

Checklist

Related issue

Fixes #566

Overview

  • Added new devtools folder to house all packages that will be used internally
    • In the future this could house shared config between different packages (eslint config, playwright setup, ...)
  • Added vite-config package which expose a defineViteConfig function that can be used to define vite config
    (who would have guess that?)
  • Removed @tanstack/config
  • Removed cjs build and related exports.
  • Streamlined package script names

TODOs

  • e2e tests are working
  • add lint and format check

@marcalexiei marcalexiei self-assigned this Feb 15, 2025
@github-actions github-actions bot added the typescript Requires typescript knowledge label Feb 15, 2025
@github-actions github-actions bot added CI/CD repo maintenance linting, fs organization, that sort of stuff labels Feb 16, 2025
@github-actions github-actions bot removed CI/CD repo maintenance linting, fs organization, that sort of stuff labels Feb 16, 2025
@github-actions github-actions bot added CI/CD repo maintenance linting, fs organization, that sort of stuff labels Feb 16, 2025
@marcalexiei marcalexiei marked this pull request as ready for review February 16, 2025 13:50
Valerioageno
Valerioageno previously approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 minor comments. LGTM! Thanks

@marcalexiei
Copy link
Member Author

Simple performance compare

Branch GitHub Actions MacBook Air M3
main ~12s ~5.4s
this PR ~4s ~2.2s

@marcalexiei marcalexiei merged commit 12e0937 into main Feb 16, 2025
20 checks passed
@marcalexiei marcalexiei deleted the build-redesign branch February 16, 2025 14:39
@marcalexiei marcalexiei mentioned this pull request Feb 16, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valerioageno Valerioageno Valerioageno left review comments

Assignees

@marcalexiei marcalexiei

Labels
CI/CD repo maintenance linting, fs organization, that sort of stuff typescript Requires typescript knowledge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create internal vite config
2 participants
@marcalexiei @Valerioageno