Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in examples #573

Closed
1 task done
jacobhq opened this issue Feb 16, 2025 · 3 comments · Fixed by #577
Closed
1 task done

Update dependencies in examples #573

jacobhq opened this issue Feb 16, 2025 · 3 comments · Fixed by #577
Assignees
Labels
enhancement New feature or request repo maintenance linting, fs organization, that sort of stuff

Comments

@jacobhq
Copy link
Member

jacobhq commented Feb 16, 2025

@jacobhq jacobhq converted this from a draft issue Feb 16, 2025
@marcalexiei
Copy link
Member

Potentially adjust renovate bot to do this in future

Could you please elaborate this point?
Right now there is no code check, nor test, performed on examples/*.
Making dependencies update automatic could break examples code.

@jacobhq
Copy link
Member Author

jacobhq commented Feb 16, 2025

Oh wait, we're not using pinned deps on them, so I don't think we need to do this. WDYT?

@marcalexiei marcalexiei added the enhancement New feature or request label Feb 16, 2025
@marcalexiei
Copy link
Member

You can update the version range removing the beta tag since v4 is now stable, You can use ^4.0.6.

Other examples dependencies should already have a dynamic range.

Also I would not consider adding them to renovate config unless there are some test in place first.

@Valerioageno Valerioageno added repo maintenance linting, fs organization, that sort of stuff enhancement New feature or request and removed enhancement New feature or request labels Feb 16, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Road to V1 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request repo maintenance linting, fs organization, that sort of stuff
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants