Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more detailed errors for Failed to read tuono.config.ts #579

Merged
merged 9 commits into from
Feb 23, 2025
Merged

feat: more detailed errors for Failed to read tuono.config.ts #579

merged 9 commits into from
Feb 23, 2025

Conversation

jacobhq
Copy link
Member

@jacobhq jacobhq commented Feb 19, 2025

Checklist

Related issue

Fixes #578

Overview

Give the user more details, as this error can appear in a few situations.

@github-actions github-actions bot added the rust Requires rust knowledge label Feb 19, 2025
@jacobhq jacobhq force-pushed the jm-improve-tuono-config-error branch from a28f1f5 to c91a58e Compare February 20, 2025 10:23
@jacobhq jacobhq marked this pull request as ready for review February 20, 2025 10:32
@jacobhq
Copy link
Member Author

jacobhq commented Feb 20, 2025

Sorry about all that CI. Windows and Linux have different errors (painful 😅)!

jacobhq
jacobhq commented Feb 21, 2025
View reviewed changes
@jacobhq jacobhq requested a review from Valerioageno February 21, 2025 14:27
@jacobhq
Copy link
Member Author

jacobhq commented Feb 21, 2025

I think the CI failure is unrelated to this PR. It might be fixed by a re-run.

@Valerioageno
Copy link
Member

Yeah this is a problem with v8. Very annoying that we have to keep the version in sync... Gonna investigate on it

@Valerioageno
Copy link
Member

Valerioageno commented Feb 23, 2025 •
edited
Loading

Can you try to merge main?

Valerioageno
Valerioageno previously approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobhq jacobhq requested a review from Valerioageno February 23, 2025 10:51
@Valerioageno Valerioageno merged commit de5ac53 into tuono-labs:main Feb 23, 2025
20 checks passed
@jacobhq jacobhq deleted the jm-improve-tuono-config-error branch February 23, 2025 11:22
@jacobhq jacobhq restored the jm-improve-tuono-config-error branch February 23, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valerioageno Valerioageno Awaiting requested review from Valerioageno Valerioageno is a code owner

Assignees

@jacobhq jacobhq

Labels
rust Requires rust knowledge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Give more context for [CLI]: Failed to read tuono.config.ts
2 participants
@jacobhq @Valerioageno