Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Test it_fails_without_installed_build_script does not work on Windows #580

Open
jacobhq opened this issue Feb 20, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jacobhq
Copy link
Member

jacobhq commented Feb 20, 2025

Description

It looks like this test uses chmod which does not exist on Windows. This causes the test to fail.

Expected behaviour

The test to run, and check that the CLI exits if there is no installed build script.

How to reproduce

On windows. Run cargo test in your tuono clone.

Screenshots

     Running tests\cli_build.rs (target\debug\deps\cli_build-51cbdde42b068855.exe)

Failed to spawn Command { cmd: "chmod" "+x" ".\\node_modules\\.bin\\tuono-build-config.cmd", stdin: None, timeout: None }: program not found
thread 'it_fails_without_installed_build_script' panicked at C:\Users\jacob\.cargo\registry\src\index.crates.io-6f17d22bba15001f\assert_cmd-2.0.16\src\cmd.rs:651:17:
Failed to spawn Command { cmd: "chmod" "+x" ".\\node_modules\\.bin\\tuono-build-config.cmd", stdin: None, timeout: None }: program not found
stack backtrace:
   0: std::panicking::begin_panic_handler
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf\library/std\src\panicking.rs:665
   1: core::panicking::panic_fmt
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf\library/core\src\panicking.rs:74
   2: assert_cmd::cmd::impl$4::assert
             at C:\Users\jacob\.cargo\registry\src\index.crates.io-6f17d22bba15001f\assert_cmd-2.0.16\src\cmd.rs:651
   3: assert_cmd::cmd::Command::assert
             at C:\Users\jacob\.cargo\registry\src\index.crates.io-6f17d22bba15001f\assert_cmd-2.0.16\src\cmd.rs:183
   4: cli_build::it_fails_without_installed_build_script::closure$0
             at C:\Users\jacob\code\tuono\crates\tuono\tests\cli_build.rs:165
   5: core::ops::function::FnOnce::call_once<cli_build::it_fails_without_installed_build_script::closure_env$0,tuple$<> >
             at C:\Users\jacob\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:250
   6: serial_test::serial_code_lock::local_serial_core
             at C:\Users\jacob\.cargo\registry\src\index.crates.io-6f17d22bba15001f\serial_test-0.10.0\src\serial_code_lock.rs:25
   7: cli_build::it_fails_without_installed_build_script
             at C:\Users\jacob\code\tuono\crates\tuono\tests\cli_build.rs:161
   8: cli_build::it_fails_without_installed_build_script::closure$0
             at C:\Users\jacob\code\tuono\crates\tuono\tests\cli_build.rs:162
   9: core::ops::function::FnOnce::call_once<cli_build::it_fails_without_installed_build_script::closure_env$0,tuple$<> >
             at C:\Users\jacob\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:250
  10: core::ops::function::FnOnce::call_once
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf\library/core\src\ops\function.rs:250
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

System Info

System:
    OS: Windows 11 10.0.26100
    CPU: (16) x64 AMD Ryzen 7 5700G with Radeon Graphics
    Memory: 3.14 GB / 15.37 GB
  Binaries:
    Node: 22.12.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.22 - ~\AppData\Local\pnpm\yarn.CMD
    npm: 11.0.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 10.2.1 - ~\AppData\Local\pnpm\pnpm.CMD
    bun: 1.1.42 - ~\.bun\bin\bun.EXE
  Browsers:
    Edge: Chromium (131.0.2903.112)

System info (Rust)

rustc 1.83.0 (90b35a623 2024-11-26)
cargo 1.83.0 (5ffbef321 2024-10-29)
tuono 0.17.8

Additional context

No response

@jacobhq jacobhq added the bug Something isn't working label Feb 20, 2025
@Valerioageno Valerioageno added the good first issue Good for newcomers label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants