Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add checks on examples #605

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

ci: add checks on examples #605

wants to merge 9 commits into from

Conversation

marcalexiei
Copy link
Member

@marcalexiei marcalexiei commented Feb 25, 2025

Checklist

Related issue

Fixes #590

Overview

See


  • dynamically create matrix with examples folders
  • add checks
    • build
    • typecheck

@marcalexiei marcalexiei self-assigned this Feb 25, 2025
@github-actions github-actions bot added the CI/CD label Feb 25, 2025
Comment on lines +65 to +68
steps:
- name: Exit with error if some jobs are not successful
run: exit 1
if: ${{ always() && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'skipped') || contains(needs.*.result, 'cancelled')) }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: this new CI OK approach simplifies the job code.
Remember to apply it to other workflows as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: add checks on examples (templates)
1 participant