Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tuono-tutorial example with changes of tuono-labs/tuono-documentation#40 #612

Closed
jacobhq opened this issue Feb 28, 2025 · 2 comments · Fixed by #613
Closed

Update tuono-tutorial example with changes of tuono-labs/tuono-documentation#40 #612

jacobhq opened this issue Feb 28, 2025 · 2 comments · Fixed by #613
Assignees

Comments

@jacobhq
Copy link
Member

jacobhq commented Feb 28, 2025

We'll need to update this in the example as well. I can do that :)

Originally posted by @jacobhq in tuono-labs/tuono-documentation#40 (comment)

@Valerioageno
Copy link
Member

What do we need to update?

@marcalexiei
Copy link
Member

marcalexiei commented Feb 28, 2025

From PR description:

I included a small tweak to the tsx snippet as well in order to:

  • render the Pokemons list in a more pleasant way (see below)
  • avoid using index for key, since it's not considered a good practice and the Pokemons names are a better candidate
Image

Since the tutorial hosted in this repo is different from the one in the linked documentation change only the key prop should be changed

@marcalexiei marcalexiei self-assigned this Feb 28, 2025
@marcalexiei marcalexiei changed the title Update example as per tuono-labs/tuono-documentation#40 Update tuono-tutorial example with changes of tuono-labs/tuono-documentation#40 Feb 28, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Road to V1 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants