Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has_phone passes for invalid phone numbers #224

Closed
HawkiesZA opened this issue Sep 26, 2024 · 1 comment · Fixed by #225
Closed

has_phone passes for invalid phone numbers #224

HawkiesZA opened this issue Sep 26, 2024 · 1 comment · Fixed by #225

Comments

@HawkiesZA
Copy link

We've been testing out has_phone in some of our flows and noticed that it's quite liberal in what passes for a phone number. In the code it seems that it's just parsing and formatting the given number and not actually calling is_possible_number and is_valid_number on it. This means that people can basically input anything with 2 or more digits and it will "validate" as a phone number.

@smn
Copy link
Contributor

smn commented Sep 26, 2024

I think #225 fixes it. It'll be part of the next release.

@smn smn closed this as completed in #225 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants