Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VALUES statements are not supported #866

Open
penberg opened this issue Feb 2, 2025 · 2 comments
Open

VALUES statements are not supported #866

penberg opened this issue Feb 2, 2025 · 2 comments
Labels
compat enhancement New feature or request

Comments

@penberg
Copy link
Collaborator

penberg commented Feb 2, 2025

We support SELECT ... VALUES in Limbo, but not plain VALUES:

limbo> VALUES
('Monty Python and the Holy Grail', 1975, 8.2),
('And Now for Something Completely Different', 1971, 7.5);
thread 'main' panicked at core/translate/select.rs:336:14:
not yet implemented
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
sqlite> VALUES
('Monty Python and the Holy Grail', 1975, 8.2),
('And Now for Something Completely Different', 1971, 7.5);
Monty Python and the Holy Grail|1975|8.2
And Now for Something Completely Different|1971|7.5
@penberg penberg added compat enhancement New feature or request labels Feb 2, 2025
@Samyak2
Copy link
Contributor

Samyak2 commented Feb 2, 2025

I want to pick this up, but I noticed something. SELECT * FROM (values(...)) is also not implemented.

sqlite> SELECT * FROM (VALUES(1, 2, 'a'));
1|2|a
limbo> SELECT * FROM (VALUES(1, 2, 'a'));
thread 'main' panicked at core/translate/select.rs:337:43:
not yet implemented
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I tried searching for values throughout the codebase and only found examples of INSERT INTO ... VALUES. So should this issue represent both SELECT ... VALUES and VALUES?

@penberg
Copy link
Collaborator Author

penberg commented Feb 2, 2025

Yeah, probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants