Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should shell .dump use a transaction? #456

Open
CodingDoug opened this issue May 30, 2023 · 1 comment
Open

Should shell .dump use a transaction? #456

CodingDoug opened this issue May 30, 2023 · 1 comment

Comments

@CodingDoug
Copy link
Contributor

sqlite3 .dump wraps the entire SQL output (after PRAGMA foreign_keys=OFF;) in BEGIN TRANSACTION; and COMMIT;. Turso's shell does not. Should it? That would defend against a partial set of statements from executing in the face of an error part way through.
@athoscouto
Copy link
Contributor

Duplicate of tursodatabase/libsql-shell-go#75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CodingDoug @athoscouto