Token not found in Error Callback instead of notFoundHandler

[ludufre]

If call a page that are not maped instead of notFoundHandler is called the error callback of this library.

I.e.: if call https://foo.bar/public/pageitenrionalynotmaped
I receive: {"status": "error", "message": "Token not found"}
I expected: Slim 404 Handler to be called

PHP 7.2.7
Slim 3.1
JWT-Auth: 3.0

[tuupola]

Confirmed, I do not remember why this is the case. Seems to date back to 2.x branch. Changing this behavior by default would be a BC break, so maybe add a configuration switch to honor 404.

Will investigate a bit.

[tuupola]

Now I remember.

By default middleware does not have any information about current route. Middleware is also executed for all requests, even those which are made against nonexistent route. As a workaround you could set determineRouteBeforeAppMiddleware => true and throw a NotFoundException when route does not exist. This will exit the middleware stack early.

For example:

<?php

require __DIR__ . "/vendor/autoload.php";

$config = [
    "settings" => [
        "determineRouteBeforeAppMiddleware" => true,
    ],
];
$app = new Slim\App($config);

$app->add(new Tuupola\Middleware\JwtAuthentication([
    "path" => "/",
    "secret" => "supersecretkeyyoushouldnotcommittogithub",
    "error" => function ($response, $arguments) {
        $data["status"] = "error";
        $data["message"] = $arguments["message"];
        return $response
            ->withHeader("Content-Type", "application/json")
            ->getBody()->write(json_encode($data, JSON_UNESCAPED_SLASHES | JSON_PRETTY_PRINT));
    }
]));

$app->add(function ($request, $response, $next) {
    $route = $request->getAttribute("route");

    if (empty($route)) {
        throw new Slim\Exception\NotFoundException($request, $response);
    }

    return $next($request, $response);
});

$app->get("/test", function ($request, $response, $arguments) {
    print "Brawndo!";
});

$app->run();

$ curl --include http://localhost:8080/test

HTTP/1.1 401 Unauthorized
Host: localhost:8080
Date: Tue, 14 Aug 2018 09:50:40 +0000
Connection: close
X-Powered-By: PHP/7.1.14
Content-Length: 60

{
    "status": "error",
    "message": "Token not found."
}

$ curl --include http://localhost:8080/nosuch

HTTP/1.1 404 Not Found
Host: localhost:8080
Date: Tue, 14 Aug 2018 09:50:46 +0000
Connection: close
X-Powered-By: PHP/7.1.14
Content-type: text/html;charset=UTF-8
Content-Length: 879

...