From 294bda2853e0c42e62eb142da6f265e0e463de21 Mon Sep 17 00:00:00 2001 From: tvallin Date: Thu, 16 Jan 2025 10:21:56 +0100 Subject: [PATCH] Upload tests result artifacts on Windows --- .github/actions/common/action.yml | 7 +++---- .github/workflows/validate.yml | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/actions/common/action.yml b/.github/actions/common/action.yml index 1ee8abeb0..a0b426d38 100644 --- a/.github/actions/common/action.yml +++ b/.github/actions/common/action.yml @@ -1,5 +1,5 @@ # -# Copyright (c) 2023, 2024 Oracle and/or its affiliates. +# Copyright (c) 2023, 2025 Oracle and/or its affiliates. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -57,7 +57,7 @@ inputs: required: false default: '' test-artifact-name: - description: Name of the test artifact to create (excluded on windows), if non empty tests are archived + description: Name of the test artifact to create, if non empty tests are archived required: false default: '' free-space: @@ -157,8 +157,7 @@ runs: run: ${{ inputs.run }} shell: bash - name: Archive test results - # https://github.com/actions/upload-artifact/issues/240 - if: ${{ inputs.test-artifact-name != '' && runner.os != 'Windows' && always() }} + if: ${{ inputs.test-artifact-name != '' && always() }} uses: actions/upload-artifact@v4 with: if-no-files-found: 'ignore' diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index cddf5a980..7217baa1f 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -1,5 +1,5 @@ # -# Copyright (c) 2023, 2024 Oracle and/or its affiliates. +# Copyright (c) 2023, 2025 Oracle and/or its affiliates. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -115,7 +115,7 @@ jobs: - uses: ./.github/actions/common with: build-cache: read-only - test-artifact-name: tests-${{ matrix.moduleSet }} + test-artifact-name: tests-${{ matrix.moduleSet }}-${{ matrix.os }} run: | mvn ${MAVEN_ARGS} \ -DreactorRule=tests \