-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't export class methods by default #56
Comments
(I don't know what the class would not be in The class methods are not an internal thing however, they very much matter if you need to define manual instances of the capabilities. It may be worth it not to export them in main modules because it can be considered avanced usage, and, possibly, it may make the documentation more approachable (though, a typeclass without methods may throw people off as well). But in that case, the type class should be exported in its entirety in some non-internal module (I don't have a name for this module at this point). |
For consistency, I'd expect every capability to have an internal module. |
I don't think internal modules should have any sort of consistency. They are, by definition, not part of my API. Rather, use-at-your-own-risk extras. |
Why not have consistency in extras too :-D |
The methods of the capability type-classes (e.g.
put_
fromHasState
) are not meant to be used directly, currently this is documented in their haddocks. With the separation of user facing modules and internal modules, such asCapability.State
andCapability.State.Internal.Class
, it is possible to not export them from the user facing modules.We should consistently separate user facing from internal modules (e.g.
Capability.Writer
vsCapability.Writer.Internal.Class
) and not export class methods in the user facing modules.cc @mrkkrp
The text was updated successfully, but these errors were encountered: