Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/23 Create node versions of bash commands which don't have them #26

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

artley
Copy link
Collaborator

@artley artley commented Oct 25, 2024

Updating scripts, create missing ones, update documentation and add test cases

Change

  • Adding missing Node scripts
  • Updating documentation
  • Removing all shell scripts
  • Adding option to test offline the new Node scripts

Does this PR introduce a breaking change?

Yes, old bash scripts are replaced with the new Node ones

What needs to be documented once your changes are merged?

Documentations is updated.

Additional Comments

N/A

@artley artley linked an issue Oct 25, 2024 that may be closed by this pull request
@artley artley changed the title Updating scripts, create missing ones, update documentation and add test cases Feature/23 Create node versions of bash commands which don't have them Oct 28, 2024
@artley artley requested a review from seanmccleary October 28, 2024 15:30
…g-bash-commands-and-delete-node-command' of github.com:tweag/gh-migration-scripts into 23-create-node-versions-of-bash-commands-which-dont-have-them
Copy link
Collaborator

@ajmalmsali ajmalmsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just like the previous PR, if commander integration is done, that would be best, and probably moving the files to inner folders would also align it with the existing ones. Just my $0.02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create node versions of bash commands which don't have them
2 participants