Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GHC 9.2 #389

Open
4 tasks
aspiwack opened this issue Feb 17, 2022 · 0 comments
Open
4 tasks

Move to GHC 9.2 #389

aspiwack opened this issue Feb 17, 2022 · 0 comments

Comments

@aspiwack
Copy link
Member

The upcoming version 0.2 will presumably be the last version where we will support GHC 9.0.

Moving to GHC 9.2 will let us benefit from the improved multiplicity inference and Core generation that we shipped there.

This issue is blocked on haskell/haskell-language-server#2179 (partially so: I think that hls will be working well enough with GHC 9.2 before this issue is closed)
This issue is blocked on Stackage publishing a snapshot for GHC 9.2

  • Change the default compiler in shell.nix to GHC 9.2
  • Change the stack snapshot to a GHC 9.2 one
  • Make sure the CI runs on GHC 9.2
  • Remove the scrutinee & \case trick, both from the documentation and from the code
aspiwack added a commit that referenced this issue May 3, 2022
I've had to do both at the same time because I don't have a Stackage
snapshot with GHC 9.0 and tasty-hedgehog 1.2.

The `testProperty` function has been deprecated in the current 1.2
version. See qfpl/tasty-hedgehog#42 for the
reason.

The `testProperty` function is replaced by `testPropertyNamed` which
requires one extra argument (the name of the test function as a
string).

There were a test for which the property didn't have a name, so I had
to name it. We also need `-XOverloadedString` in every module (some
already have it).

Upgrading the stack snapshot to GHC 9.2 didn't require any action.

Upgrading the stack snapshot is part of #389.
@aspiwack aspiwack mentioned this issue May 3, 2022
2 tasks
aspiwack added a commit that referenced this issue May 3, 2022
I've had to do both at the same time because I don't have a Stackage
snapshot with GHC 9.0 and tasty-hedgehog 1.2.

The `testProperty` function has been deprecated in the current 1.2
version. See qfpl/tasty-hedgehog#42 for the
reason.

The `testProperty` function is replaced by `testPropertyNamed` which
requires one extra argument (the name of the test function as a
string).

There were a test for which the property didn't have a name, so I had
to name it. We also need `-XOverloadedString` in every module (some
already have it).

Upgrading the stack snapshot to GHC 9.2 didn't require any action.

Upgrading the stack snapshot is part of #389.
aspiwack added a commit that referenced this issue May 6, 2022
Upgrading the stack snapshot is part of #389.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant