Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Monaco editor instead of Ace? #334

Open
matthew-healy opened this issue Oct 27, 2022 · 2 comments
Open

Use Monaco editor instead of Ace? #334

matthew-healy opened this issue Oct 27, 2022 · 2 comments

Comments

@matthew-healy
Copy link
Contributor

matthew-healy commented Oct 27, 2022

Currently the playground uses Ace as its editor UI. In general this seems to work well, but it requires us to maintain custom syntax highlighting code which can become out of sync with the current state of the language (as happened here).

If we were to instead use Microsoft's Monaco editor, we could reuse the language configuration defined in this vscode extension, which should be less likely to get out of sync.

@yannham
Copy link
Member

yannham commented Oct 28, 2022

Does Monaco supports LSP? This would be a double-win, because we currently have a kind of proto-LSP built in WASM in order to show errors directly inside the editor. It's obviously much less featured, and yet something else to maintain.

@matthew-healy
Copy link
Contributor Author

I haven't looked into it in any detail, but the lsp docs seem to suggest that it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants