Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezone Picker freezes the page when open #9663

Closed
pacyL2K19 opened this issue Jan 16, 2025 · 4 comments · May be fixed by #9896
Closed

Timezone Picker freezes the page when open #9663

pacyL2K19 opened this issue Jan 16, 2025 · 4 comments · May be fixed by #9896
Assignees
@charlesBochet
Labels
prio: high scope: front Issues that are affecting the frontend side only

Comments

@pacyL2K19
Copy link
Contributor

Bug Description

Setting > Appearance > Date and Time: When the timezone dropdown open, the clickOutside event doesn't have any effect, and the page appears to freeze until I reload it (see the recording below)

https://drive.google.com/file/d/1wbcYte8vXAy_LlRd9B797rXKwNDVhIiv/view?usp=sharing

Expected behavior

  • The page should not freeze when trying to search for a timezone

Technical inputs

  • Improve the fetching of timezones - there is a short delay when a user clicks on the timezone dropdown before it display the content, we should probably fetch timezones and cache when the page loads

@FelixMalfait @magrinj
@Bonapara Bonapara added the scope: front Issues that are affecting the frontend side only label Jan 16, 2025
@Bonapara
Copy link
Member

Bonapara commented Jan 16, 2025 •
edited
Loading

Hi @pacyL2K19! What browser are you using? Can't reproduce on Chrome

@pacyL2K19
Copy link
Contributor Author

Hi @pacyL2K19! What browser are you using? Can't reproduce on Chrome

Hi @Bonapara I'm also using Chrome on a M3 MacBook pro
Tried multiple times, I'll check again in a few

@FelixMalfait
Copy link
Member

I can also reproduce in dev env. I haven't tried in prod / investigated. There is definitely an issue 👍

@ijreilly
Copy link
Collaborator

thanks @pacyL2K19
As for me I was able to reproduce only when my chrome inspector was open. I did notice also that the dropdown is slow to open but that's probably a different topic.

Spoke with @lucasbordeau according to whom this has been an issue for a long time, classifying it as a high bug to tackle it before the next release

@charlesBochet charlesBochet moved this to 🔖 Planned in 🎯 Roadmap & Sprints Jan 20, 2025
@mdrazak2001 mdrazak2001 mentioned this issue Jan 28, 2025
Open
@charlesBochet charlesBochet moved this from 🔖 Planned to 🏗 In Progress in 🎯 Roadmap & Sprints Jan 29, 2025
@charlesBochet charlesBochet moved this from 🏗 In Progress to ✅ Done in 🎯 Roadmap & Sprints Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesBochet charlesBochet

Labels
prio: high scope: front Issues that are affecting the frontend side only
Projects
🎯 Roadmap & Sprints
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optimize timezone dropdown with virtualization and memoization mdrazak2001/twenty
7 participants
@FelixMalfait @charlesBochet @Bonapara @lucasbordeau @etiennejouan @ijreilly @pacyL2K19