Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't permanently delete soft-deleted items #110

Open
Bonapara opened this issue Sep 16, 2024 · 10 comments · May be fixed by twentyhq/twenty#9991
Open

Can't permanently delete soft-deleted items #110

Bonapara opened this issue Sep 16, 2024 · 10 comments · May be fixed by twentyhq/twenty#9991
Assignees
Labels
prio: high scope: backend Issues that are affecting the backend side only size: long

Comments

@Bonapara
Copy link
Member

Bug description

CleanShot.2024-09-16.at.17.12.05.mp4

Can't permanently delete soft-deleted items. This seems to cause a significant lag afterward as well.

@Bonapara Bonapara added scope: backend Issues that are affecting the backend side only size: long prio: high labels Sep 16, 2024
@Bonapara
Copy link
Member Author

@charlesBochet you may want to have a look

@charlesBochet
Copy link
Member

Yes, @Weiko has seen it.
@Weiko assigning it to you

@FelixMalfait
Copy link
Member

Also tracked here fyi: #114

@FelixMalfait
Copy link
Member

@bosiraphael maybe you can add this to your backlog since it's related to the action bar? (show different action to permanently delete instead of soft delete based on context). Thanks!

@Bonapara Bonapara transferred this issue from twentyhq/twenty Jan 10, 2025
@charlesBochet
Copy link
Member

This should be done, double check on production

@charlesBochet charlesBochet assigned prastoin and unassigned bosiraphael Feb 3, 2025
@charlesBochet charlesBochet moved this to 🔖 Planned in 🎯 Roadmap & Sprints Feb 3, 2025
@prastoin
Copy link

prastoin commented Feb 4, 2025

Update

Unless I'm mistaken I can't find the destroy call to action for either both multiple or single record deletion in production. ( tested in two workspaces with default record and custom record )
On main I can see a destroy CTA for single selection only ?

Maybe I'm doing the recipe wrong @charlesBochet ?

Image

@prastoin prastoin moved this from 🔖 Planned to 🏗 In Progress in 🎯 Roadmap & Sprints Feb 4, 2025
@charlesBochet
Copy link
Member

We might not have implemented it, could you take it in your current sprint? Should be quite straight forward as we already have the delete many implementation and the destroy one.

@prastoin
Copy link

prastoin commented Feb 4, 2025

Yep no problem, I just would like to clarify if there's any outgoing regression as it might change the way I look forward
Especially on the delete destroy one in production

@charlesBochet
Copy link
Member

charlesBochet commented Feb 4, 2025

@prastoin
Copy link

prastoin commented Feb 4, 2025

Which one, Multiple or single ?
As Unless i'm mistaken the destroy one record seems to be implemented line 149 in the file you shared ?
https://github.com/twentyhq/twenty/blob/main/packages/twenty-front/src/modules/action-menu/actions/record-actions/constants/DefaultActionsConfigV2.ts#L149

@prastoin prastoin linked a pull request Feb 4, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high scope: backend Issues that are affecting the backend side only size: long
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

6 participants