Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test harness #23

Open
dkundel opened this issue Jul 19, 2019 · 2 comments
Open

Improve test harness #23

dkundel opened this issue Jul 19, 2019 · 2 comments
Assignees

Comments

@dkundel
Copy link
Member

dkundel commented Jul 19, 2019

As mentioned in #18 we should be improving the test harness. I think we should be leveraging parts of the twilio-run tool for this since it is already putting effort in simulating the Twilio Runtime and therefore provides the right globals etc.

That way we only need to maintain one implementation to stay in sync with the actual Runtime.

@philnash
Copy link
Contributor

Yeah, this is a good idea. What do you think to extracting the Runtime part of twilio-run to a twilio-runtime-mock module that the modules could share? (This small modules thing gets addictive doesn't it?) I guess it would be easier to have this repo depend on twilio-run and just pull the necessary bits out.

@dkundel
Copy link
Member Author

dkundel commented Jul 23, 2019

Yeah I would say for now let's pull in twilio-run especially because it would also mean that you could easily manually test them by running twilio-run [path] but yeah I was thinking of pulling it out. We should create an issue for it for post SIGNAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants