Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Escape date/time separators #597

Closed
wants to merge 4 commits into from

Conversation

zornwal
Copy link

@zornwal zornwal commented Jan 26, 2022

Escape date and time separators to avoid using system/culture defaults, as defaults are not - for dates and : for time in all cultures.

Fixes

Fixes #596

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
    • passing existing date serialization test should be sufficient
  • I have added the necessary documentation about the functionality in the appropriate .md file
    • This should not be a breaking change - but has the chance to be if people have written very stupid code to change the produced request object instead of changing cultures.
  • I have added inline documentation to the code I modified

zornwal and others added 3 commits January 26, 2022 15:41
Escape date and time separators to avoid using system/culture defaults.
@childish-sambino
Copy link
Contributor

childish-sambino commented Feb 18, 2022

Thanks for the submission! Could you add unit tests that verify the expected behavior when the system/culture values are not the default?

@beebzz
Copy link

beebzz commented Mar 22, 2022

Closing due to inactivity, feel free to ping again if the requested changes can be made.

@beebzz beebzz closed this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageResource.CreateAsync throws formatting exception when supplying C# DateTime to sendAt parameter
3 participants