Wrong validation on accountSid when using API Sid/Api Key to initialize the client

[vence722]

Issue Summary

When initialize the client using API Sid/Key, validation still applied to the username field which will check if the field starts with 'AC'. But API Sid should start with 'SK'.

Steps to Reproduce

Initialize the twilio SDK client using API Sid/Key

Code Snippet

import twilio from 'twilio'
twilio(apiSid, apiKey)

Exception/Log

Error: accountSid must start with AC
    at new Twilio (/var/task/node_modules/twilio/lib/rest/Twilio.js:137:11)
    at Object.initializer [as default] (/var/task/node_modules/twilio/lib/index.js:9:10)
    at new Twilio (/var/task/src/services/twilio.js:9:39)
    at initTwilio (/var/task/src/controllers/sms.js:19:16)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Object.sendVerification (/var/task/src/controllers/sms.js:49:28)

Technical details:

• twilio-node version: 3.48.0
• node version: 13.12.0

[childish-sambino]

This is similar to twilio/twilio-csharp#531, but the Node lib is also expecting an account SID in this case.

The fix is to include the account SID in optional params. E.g.:

twilio(apiSid, apiKey, { accountSid });

[vence722]

@childish-sambino Yes, this is my work-around too. I can even use a dummy value of accountSid to bypass the validation. E.g.:

twilio(apiSid, apiKey, { accountSid: 'AC' })

However, I still get a feeling that this is a bug in the twilio node library, as the document mentions that twilio() function could accept both accountSid/accountSecret and apiSid/apiKey pairs. Hope this could get fixed in the future version. Thank you!

[childish-sambino]

Probably need a similar implementation here as twilio/twilio-csharp#533

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

[ducsuus]

I believe this is an important issue to address, even if just to update the error message thrown to explain the different requirements for API Keys.

At present, I understand that this behaviour is not described in the documentation. Because the error thrown suggests that API Keys cannot be used instead of account auth tokens, developers are encouraged to avoid using API Keys, which is poor practice.

If the account SID begins with "SK", a different error message could be provided:

accountSid must start with AC. The SID provided indicates an API Key, which requires the accountSid to be passed as one of the options in the third parameter: {accountSid: "ACXXX}

[jlcaicedo]

The solution is very easy, when you should use the Account SID you would verify this account start by AC

[childish-sambino]

Fixed by #828