Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatrack send errors are not being logged #1509

Closed
4 tasks done
EdGallimore opened this issue Jun 25, 2021 · 2 comments
Closed
4 tasks done

Datatrack send errors are not being logged #1509

EdGallimore opened this issue Jun 25, 2021 · 2 comments
Assignees

Comments

@EdGallimore
Copy link

EdGallimore commented Jun 25, 2021

  • I have verified that the issue occurs with the latest twilio-video.js release and is not marked as a known issue in the CHANGELOG.md.
  • I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
  • I verified that the Quickstart application works in my environment.
  • I am not sharing any Personally Identifiable Information (PII)
    or sensitive account information (API keys, credentials, etc.) when reporting this issue.

(Closed and consolidated with issue: #1510)

Behaviour
Our application connects to a room, publishes a dataTrack and immediately attempts to send a message to the other participants in the room. This message is not received by the other participants. No error is thrown when calling the send method is called

Observation
On investigation it seems possible the send method might be throwing an error (given the state of the connection). But it appears that the DataTrackSender twillio-video implementation swallows errors (rather than handling or even logging them to the logger)
Code snippet from twilio-video below

 send(data) {
    this._dataChannels.forEach(dataChannel => {
      try {
        dataChannel.send(data);
      } catch (error) {
        // Do nothing.
      }
    });
    this._clones.forEach(clone => {
      try {
        clone.send(data);
      } catch (error) {
        // Do nothing.
      }
    });
    return this;
  }

Software versions:
Chrome v89 on MacOs
twilio-video.js 2.15.1
react 17.0.2

@charliesantos
Copy link
Collaborator

@EdGallimore the repro steps seems very similar to this other issue you filed #1510 . Can you combine both if possible?

@EdGallimore
Copy link
Author

(Closed and consolidated with issue: #1510)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants