Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twilio future development discussion: esm & following node release schedule #1527

Open
7 of 8 tasks
Niputi opened this issue Jul 23, 2021 · 6 comments
Open
7 of 8 tasks
Assignees

Comments

@Niputi
Copy link

Niputi commented Jul 23, 2021

  • I have verified that the issue occurs with the latest twilio-video.js release and is not marked as a known issue in the CHANGELOG.md.
  • I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
  • I verified that the Quickstart application works in my environment.
  • I am not sharing any Personally Identifiable Information (PII)
    or sensitive account information (API keys, credentials, etc.) when reporting this issue.

Code to reproduce the issue:

https://github.com/Niputi/vite-tests/tree/twilio-video

Expected behavior:

  • being able to import this module and other twilio modules without having to use a bundler.
  • being able to import into modern build tools like Vite.js, snowpack and esbuild without workarounds
  • Not relying on node built-ins.
  • moving to esm output or having multi output via rollup, a build for browsers, one for node.js environment and potentially output for deno.

I see the package.json of this module declares that it can be used from version 0.12 of node.js.
if modules code structure would be following node release schedule, it would help help with #1272

Actual behavior:

can't use twilio modules in esm environment without workarounds

TODO

Software versions:

  • Browser(s): Microsoft Edge, Version 93.0.953.0 (Official build) (64-bit)
  • Operating System: windows
  • twilio-video.js: 2.15.2
  • Third-party libraries (e.g., Angular, React, etc.): vanilla js with
@charliesantos charliesantos self-assigned this Jul 23, 2021
@charliesantos
Copy link
Collaborator

@Niputi thanks for this suggestion! This is definitely an improvement and our team will consider it. However, this is currently low in priority due to other higher priority product features. But we can keep this open and continue the discussion.

@acupofspirt
Copy link

acupofspirt commented Aug 10, 2021

+1 More and more VueJS projects are migrating now from vue-cli (Webpack) to vite (Rollup). There is a real demand for twilio js sdk to be bundler-agnostic.

@Niputi could you tell what workarounds have you managed to find?

@charliesantos
Copy link
Collaborator

I submitted an internal ticket to investigate this further.

@acupofspirt
Copy link

@charliesantos any updates?

@ju4n97
Copy link

ju4n97 commented Sep 3, 2021

I'm getting this kind of error when I try to use twilio-video^2.16.0 with sveltekit or Angular 12

Sveltekit
image

Angular12
image

Is there any workaround to this?

@Miserlou
Copy link

Is this project still being actively developed? Would really, really like ESM.

@luisrivas luisrivas self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants