Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function that downloads a review (independent of CWD) and opens an (editable) overview of the change #19

Open
twmr opened this issue Sep 16, 2021 · 1 comment · May be fixed by #20
Open

Function that downloads a review (independent of CWD) and opens an (editable) overview of the change #19

twmr opened this issue Sep 16, 2021 · 1 comment · May be fixed by #20

Comments

@twmr
Copy link
Owner

twmr commented Sep 16, 2021 •
edited
Loading

A new function would be nice that:

  • finds the workspace of the project on the host (we need to introduce a mapping from (projectname + branch) to the directory of the workspace on the host)
  • switches the working directory to this workspace and downloads the change
  • opens a overview of the change in which
    ** modified files can easily be opened in a new buffer
    ** the displayed diff hunks can easily be edited inline (requires a fix for Make it possible to edit diff magit/magit#2938)

Functions which can be used for implementing this feature:

  • (magit-show-commit "HEAD")
  • magit-diff-visit-worktree-file
  • (gerrit-download)
@twmr twmr changed the title New function that downloads a review and opens an overview of the change (ideally also allow editing diff in this overview page) Function that downloads a review (independent of CWD) and opens an (editable) overview of the change Sep 16, 2021
twmr added a commit that referenced this issue Sep 21, 2021
@twmr
Improve support for selecting and downloading changes
36686c6 
This change adds support for selecting and downloading changes that
match a custom gerrit query (e.g. "is:open").

A new interactive function called `gerrit-download-and-open-overview'
was added which downloads the change and opens an magit-commit buffer
using `magit-show-commit'. (It the downloaded change is at the top of a
relation chain, the other commits are currently not displayed by this
`gerrit-download-and-open-overview' function.

Closes: #19
Change-Id: Ie3ed04a8f212cb8c0a98745d1dca4f680f420642
@twmr twmr linked a pull request Sep 21, 2021 that will close this issue
Open
twmr added a commit that referenced this issue Sep 21, 2021
@twmr
Refactor change selection code
24ebff7 
This is a preparation for #19.

A new variable called gerrit-change-singleline-columns was intoduced,
which allows configuring the columns which are shown in the minibuffer.

Change-Id: Ie0d0fe43b46e6371c9ddc5704514072d4b1dad14
twmr added a commit that referenced this issue Sep 21, 2021
@twmr
Improve support for selecting and downloading changes
ab3d78e 
A new interactive function called `gerrit-download-and-open-overview'
was added which downloads the change and opens an magit-commit buffer
using `magit-show-commit'. (It the downloaded change is at the top of a
relation chain, the other commits are currently not displayed by this
`gerrit-download-and-open-overview' function.

Closes: #19
Change-Id: Ie3ed04a8f212cb8c0a98745d1dca4f680f420642
@twmr twmr mentioned this issue Oct 2, 2021
Merged
@twmr
Copy link
Owner Author

twmr commented Oct 2, 2021

finds the workspace of the project on the host (we need to introduce a mapping from (projectname + branch) to the directory of the workspace on the host)
switches the working directory to this workspace and downloads the change

This was implemented in #23

twmr added a commit that referenced this issue Oct 2, 2021
@twmr
Add minor comments
7d92c6b 
Related: #19
Change-Id: I5653c9fc3a5c8a44f8b61da4182394ae41aaa6c6
twmr added a commit that referenced this issue Oct 2, 2021
@twmr
(WIP) Improve support for selecting and downloading changes
f47c38e 
This change adds support for selecting and downloading changes that
match a custom gerrit query (e.g. "is:open").

A new interactive function called gerrit-download-and-open-overview' was
added which downloads the change and opens an magit-commit buffer using
magit-show-commit'. (It the downloaded change is at the top of a
relation chain, the other commits are currently not displayed by this
`gerrit-download-and-open-overview' function.

Closes: #19
Change-Id: Ie3ed04a8f212cb8c0a98745d1dca4f680f420642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(WIP) Improve support for selecting and downloading changes twmr/gerrit.el
1 participant
@twmr