From 2f8e0feaaca37a4cc37e9c09d3a4c426843a6196 Mon Sep 17 00:00:00 2001 From: Cody Allen Date: Tue, 17 May 2016 05:55:27 -0400 Subject: [PATCH] Use more descriptive binding name in Xor.combine Per @non's suggestion. --- core/src/main/scala/cats/data/Xor.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/scala/cats/data/Xor.scala b/core/src/main/scala/cats/data/Xor.scala index f7f2a1d467..427fd011c1 100644 --- a/core/src/main/scala/cats/data/Xor.scala +++ b/core/src/main/scala/cats/data/Xor.scala @@ -167,9 +167,9 @@ sealed abstract class Xor[+A, +B] extends Product with Serializable { * }}} */ final def combine[AA >: A, BB >: B](that: AA Xor BB)(implicit BB: Semigroup[BB]): AA Xor BB = this match { - case l @ Xor.Left(_) => l + case left @ Xor.Left(_) => left case Xor.Right(b1) => that match { - case l @ Xor.Left(_) => l + case left @ Xor.Left(_) => left case Xor.Right(b2) => Xor.Right(BB.combine(b1, b2)) } }