From a97b299b967816902b2f9235b25abd4851d03752 Mon Sep 17 00:00:00 2001 From: satorg Date: Sat, 3 Feb 2024 13:42:58 -0800 Subject: [PATCH] replace other `Applicative.pure(())` with `.unit` --- free/src/test/scala/cats/free/FreeTSuite.scala | 14 +++++++------- .../src/main/scala/cats/laws/ApplicativeLaws.scala | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/free/src/test/scala/cats/free/FreeTSuite.scala b/free/src/test/scala/cats/free/FreeTSuite.scala index 4916ecf040..fa1a538b1b 100644 --- a/free/src/test/scala/cats/free/FreeTSuite.scala +++ b/free/src/test/scala/cats/free/FreeTSuite.scala @@ -72,7 +72,7 @@ class FreeTSuite extends CatsSuite { checkAll("FreeT[Option, Option, Int", DeferTests[FreeTOption].defer[Int]) test("FlatMap stack safety tested with 50k flatMaps") { - val expected = Applicative[FreeTOption].pure(()) + val expected = Applicative[FreeTOption].unit val result = Monad[FreeTOption].tailRecM(0)((i: Int) => if (i < 50000) @@ -85,9 +85,9 @@ class FreeTSuite extends CatsSuite { } test("Stack safe with 50k left-associated flatMaps") { - val expected = Applicative[FreeTOption].pure(()) + val expected = Applicative[FreeTOption].unit val result = - (0 until 50000).foldLeft(Applicative[FreeTOption].pure(()))((fu, i) => + (0 until 50000).foldLeft(Applicative[FreeTOption].unit)((fu, i) => fu.flatMap(u => Applicative[FreeTOption].pure(u)) ) @@ -95,7 +95,7 @@ class FreeTSuite extends CatsSuite { } test("Stack safe with flatMap followed by 50k maps") { - val expected = Applicative[FreeTOption].pure(()) + val expected = Applicative[FreeTOption].unit val result = (0 until 50000).foldLeft(().pure[FreeTOption].flatMap(_.pure[FreeTOption]))((fu, i) => fu.map(identity)) @@ -110,7 +110,7 @@ class FreeTSuite extends CatsSuite { } test("mapK stack-safety") { - val a = (0 until 50000).foldLeft(Applicative[FreeTOption].pure(()))((fu, i) => + val a = (0 until 50000).foldLeft(Applicative[FreeTOption].unit)((fu, i) => fu.flatMap(u => Applicative[FreeTOption].pure(u)) ) val b = a.mapK(FunctionK.id) @@ -126,7 +126,7 @@ class FreeTSuite extends CatsSuite { } test("compile stack-safety") { - val a = (0 until 50000).foldLeft(Applicative[FreeTOption].pure(()))((fu, i) => + val a = (0 until 50000).foldLeft(Applicative[FreeTOption].unit)((fu, i) => fu.flatMap(u => Applicative[FreeTOption].pure(u)) ) val b = a.compile(FunctionK.id) // used to overflow @@ -147,7 +147,7 @@ class FreeTSuite extends CatsSuite { type F[A] = FreeT[Id, Option, A] val F = MonadError[F, Unit] - val eff = F.flatMap(F.pure(()))(_ => F.raiseError[String](())) + val eff = F.flatMap(F.unit)(_ => F.raiseError[String](())) assert(F.attempt(eff).runM(Some(_)) === Some(Left(()))) } diff --git a/laws/src/main/scala/cats/laws/ApplicativeLaws.scala b/laws/src/main/scala/cats/laws/ApplicativeLaws.scala index d2538fcc94..a0109f7d0f 100644 --- a/laws/src/main/scala/cats/laws/ApplicativeLaws.scala +++ b/laws/src/main/scala/cats/laws/ApplicativeLaws.scala @@ -66,10 +66,10 @@ trait ApplicativeLaws[F[_]] extends ApplyLaws[F] { // Semigroupal's associativity law. def monoidalLeftIdentity[A](fa: F[A]): (F[(Unit, A)], F[A]) = - (F.product(F.pure(()), fa), fa) + (F.product(F.unit, fa), fa) def monoidalRightIdentity[A](fa: F[A]): (F[(A, Unit)], F[A]) = - (F.product(fa, F.pure(())), fa) + (F.product(fa, F.unit), fa) } object ApplicativeLaws {