Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json data createdAt and updatedAt is not compliant with API's iso-8601 date format #2

Closed
digitalsatori opened this issue Sep 26, 2018 · 2 comments
Closed

json data createdAt and updatedAt is not compliant with API's iso-8601 date format #2

digitalsatori opened this issue Sep 26, 2018 · 2 comments

Comments

@digitalsatori
Copy link

running Api provided run-api-tests.sh script and got AssertionError for the date format.
I guess this is the related aeson issue: haskell/aeson#620
@tzemanovic
Copy link
Owner

Yep, the tests fail despite the timestamps having a ISO-8601 format.

I've opened a PR to improve the tests gothinkster/realworld#260, with these changes the tests do pass. Previously, they were just converting them to JS Date and back using toISOString, but that removes the extra precision and hence don't match the originals.

@digitalsatori
Copy link
Author

Thanks for the explaination. just realized that ISO-8601 can represent datetime with arbitrary precision. The one generated by your system is totally valid in terms of ISO-8601 format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@digitalsatori @tzemanovic