Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request does not need to be a dependency #63

Closed
craigdsthompson opened this issue Oct 10, 2024 · 1 comment
Closed

request does not need to be a dependency #63

craigdsthompson opened this issue Oct 10, 2024 · 1 comment

Comments

@craigdsthompson
Copy link

The request package is not used directly by node-canvas-api. It's a peerDependency of request-promise, so we can remove it from package.json and let npm sort of the dependencies for package-lock.json

node-canvas-api/package.json

Line 27 in 43f5e6e

"request": "^2.88.2",

@justin0022
Copy link
Member

Resolved in #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@craigdsthompson @justin0022