-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate ways to communicate with Google Calendar API #11
Comments
https://developers.google.com/calendar/quickstart/go @kx-chen @jackyzha0 @gokcedilek I've created a branch following this article, but I'm still quite unfamiliar with golang best practices so:
We can either discuss here or I can open an empty PR for a Request for Comments |
Note that credentials.json has been stored in Google Drive How to use
|
folders in Go create submodules, so if we do go down this route, the folder could be renamed to |
Go cleans up unused deps so you shouldn't need to worry about it! |
What are the other options here? |
I would recommend putting this somewhere not in the Projects drive (which has very liberal access), and also you should immediately invalidate and regenerate your key, since it is still available in Git history: c0e7c4c Why we don't put secrets in Drive: https://docs.ubclaunchpad.com/handbook/tools/drive |
Honestly this is probably the most idiomatic way to do it in Go and probably cleanest way to go about it If we kept GCal logic spread throughout our code, that's a lot of coupling |
@bobheadxi Any recommendations where we should put these vulnerable files? |
Can you add this to the PR description? Would be easier to access for reviewers. |
Unfortunately not at the moment 😞 ubclaunchpad/rocket2#557 (@SarahBornais) is an idea, but that won't be available for a while. I would recommend that this file not be shared at all:
If you really want to share it, I would keep it on someone's personal drive and just share the specific file only |
Ideally we would want to synchronize the data in the user's Google Calendar with Firebase, so that the availabilities will live update when events are added/removed.
The text was updated successfully, but these errors were encountered: