You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Command class functions shouldn't do multiple conflicting things at once, and should delegate to other functions.
Requirements
Extract functions out of command class functions that don't do 1 distinct thing (up to the required level of abstraction, of course).
Context
While refactoring some tests, I came across the function in app/controller/command/commands/team.py:552 lead_helper(), which handles both the deletion and the addition of a team lead. While this was acceptable a bit further up the line, where we parse the actual team command (and where it made sense to only have 1 function there), it doesn't make sense to not split this function here.
There are probably a lot more of these types of functions. Functions that got too big for their own good. And now it is time to cut them down.
The text was updated successfully, but these errors were encountered:
Summary
Command class functions shouldn't do multiple conflicting things at once, and should delegate to other functions.
Requirements
Extract functions out of command class functions that don't do 1 distinct thing (up to the required level of abstraction, of course).
Context
While refactoring some tests, I came across the function in
app/controller/command/commands/team.py:552 lead_helper()
, which handles both the deletion and the addition of a team lead. While this was acceptable a bit further up the line, where we parse the actual team command (and where it made sense to only have 1 function there), it doesn't make sense to not split this function here.There are probably a lot more of these types of functions. Functions that got too big for their own good. And now it is time to cut them down.
The text was updated successfully, but these errors were encountered: