-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI / dev experience remaining issues #28
Comments
lerna bump typically only bumps modules in the workspace. Since example/ and website/ are not in the workspace (and supposedly not), it is not necessary for "bump" to work for them. |
But that will create confusion. Imagine someone new will have to go to |
Not sure if this is a relevant comment, but I prefer using synchronized versioning of submodules. I.e. all modules get published with the same version even if only some have changed. That version is then in |
We are already doing that |
I changed my mind and I think aligning the versions on website/ and example/ is actually a good idea, because we will have a documentation website later on and the documentation version should align with the module versions, so should be the demo in or referenced by the documentation. To do so you can make some scripts following the lerna bump to copy over the version number from the modules to the docs/websites. |
ocular-publish
only bumps versions inmodules
package.jsonimport Manifold from '@mlvis/manifold'
to not work Publish #27The text was updated successfully, but these errors were encountered: