Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Get rid of getattr in modules generated with thrift.load. #306

Open
abhinav opened this issue Nov 13, 2015 · 0 comments
Open

Get rid of getattr in modules generated with thrift.load. #306

abhinav opened this issue Nov 13, 2015 · 0 comments

Comments

@abhinav
Copy link
Contributor

abhinav commented Nov 13, 2015

This should be fairly trivial. We already iterate through all services and setattr them on the generated module. The same could be done for types, includes, and constants.

Worth noting that these attributes were renamed from foo to __foo__ in 1.0 and __includes__ is new in 1.0. So the code will have to use some hasattrs when doing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant