Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Hyperbahn: Place an upper bound on ttl #1142

Open
Raynos opened this issue Aug 11, 2015 · 4 comments
Open

Hyperbahn: Place an upper bound on ttl #1142

Raynos opened this issue Aug 11, 2015 · 4 comments
Labels

Comments

@Raynos
Copy link
Contributor

Raynos commented Aug 11, 2015

Hyperbahn currently forwards with unlimited ttl.

This is a resource leak; we should fix it in two ways.

  • Apply a maxPending check on peers.
  • Enforce that the ttl is no larger then MAXIMUM_TTL ( 30 seconds ? ).
@prashantv
Copy link
Contributor

How should this interact with streaming?

@Raynos
Copy link
Contributor Author

Raynos commented Aug 11, 2015

@prashantv

There has been consensus that the ttl for streaming is "time until first response frame".

For streaming to work you just have to send a streaming response within 30 seconds.

@prashantv
Copy link
Contributor

I meant how streaming's lack of timeout can very easily cause resource leaks. It means that any bug in a streaming server/client will leak resources on Hyperbahn, which seems pretty dangerous.

@Raynos
Copy link
Contributor Author

Raynos commented Aug 12, 2015

@prashantv

Hyperbahn will figure out how to avoid resource leaking once we implement fixed object pooling. At that point once we can't allocate any more "objects" we just return Busy or something.

@kriskowal kriskowal added the node label Aug 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants