Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

TChannel: serviceName for the origin of an error frame. #1264

Open
Raynos opened this issue Sep 3, 2015 · 0 comments
Open

TChannel: serviceName for the origin of an error frame. #1264

Raynos opened this issue Sep 3, 2015 · 0 comments
Labels

Comments

@Raynos
Copy link
Contributor

Raynos commented Sep 3, 2015

To be able to effective logging, rate limiting, circuit breaking and alerting it is good to differentiate between

  • A hyperbahn worker generates a Busy frame because its busy
  • A service Foo generates a Busy frame and we are forwarding an error frame.

If we forward an error frame then we do not need to logger.warn().
If we are generating Busy frames then we should actually logger.warn() and alert above a threshold.

This would allows us to improve the smarts of our RelayRequest.logError() method to give us the right level of insight in terms of info/warn/error and as a consequence give us the right level of insight in terms of should we alert on the cluster being unhealthy.

@Raynos Raynos added the node label Sep 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant