TChannel Node: Implement getThriftCodec on HyperbahnClient

[Raynos]

var tchannelThrift = hyperbahnClient.getThriftCodec({
    serviceName: 'steve'
    thriftFile: path.join(__dirname, 'thrift', 'steve.thrift'),
    timeout: 500 /* optional better default timeout for steve */
});

The idea is to hide the sub channel behind the thrift codec interface so that people dont have to know about sub channels.

This allows application developers to make requests like:

tchannelThrift.request({
    parent: inReq /* noParent: true */
}).send('Steve::doSomething', null, {
    /* body arguments */
}, function onResponse(err, response) {
    /* handle response */
});

[Raynos]

cc @jcorbin @rf @kriskowal ^

cc @jeloi for the initial idea :)

[jcorbin]

sgtm

[rf]

I like it, but how about getThriftService? codec is really generic

[kriskowal]

Maybe getThriftChannel. What you’re getting has the shape of a channel. Code/Decode is the same as Read/Write and you’re not getting a ThriftRW.

Is this the best way to hide sub-channels? Should we hide sub-channels? The way to hide sub-channels is to present SubChannel as the Channel constructor folks use, which in turn constructs the topChannel on your behalf.

[Raynos]

This suggestion is not really about "hiding sub channels". The sub channel implementation detail is just hidden from the user with this method.

This method is all about simplifying the step from "I have a hyperbahn client" to "I make a thrift RPC call".