Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Don't retry on unexpected Exception #1392

Open
jc-fireball opened this issue Oct 14, 2015 · 3 comments
Open

Don't retry on unexpected Exception #1392

jc-fireball opened this issue Oct 14, 2015 · 3 comments
Labels

Comments

@jc-fireball
Copy link
Contributor

This is created based on some feedback from our existing users.

The unexpected exception error happens because tchannel captures uncaught exceptions from endpoint handler on the side and then send unexpected error frame back to the client. Right now by default client will retry on unexpected error frame.

However most of the case if the unexpected error happens, probably the user's handler code has some bug causing this. Even we do retry and redirect to other server instance. The instance most likely has the same code deployed. It doesn't make sense to retry on this. It just waste time.

So we may change the protocol to not retry or only retry on certain flag.

@Raynos
Copy link
Contributor

Raynos commented Oct 14, 2015

Let's improve protocol retry flags.

Instead of nt lets have unt.

In that PR we can talk about recommended defaults; probably un by default for back compat.

@jcorbin
Copy link
Contributor

jcorbin commented Oct 17, 2015

I could agree with adding a "u" flag to opt in for "retry on unexpected error", but it should not default on; retrying on unexpected error seems wrong to me.

@Raynos
Copy link
Contributor

Raynos commented Oct 17, 2015

Let's also sync up with @mranney about the default.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants