Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

TChannel does not exit cleanly #150

Open
Raynos opened this issue Mar 12, 2015 · 2 comments
Open

TChannel does not exit cleanly #150

Raynos opened this issue Mar 12, 2015 · 2 comments
Labels

Comments

@Raynos
Copy link
Contributor

Raynos commented Mar 12, 2015

When you call channel.close() tchannel still accepts incoming CallRequests.

Pr coming.

@Raynos
Copy link
Contributor Author

Raynos commented Mar 12, 2015

More context:

/home/uber/autobahn/node_modules/tchannel/index.js:286
        throw new Error('cannot send() to destroyed tchannel'); // TODO typed
              ^
Error: cannot send() to destroyed tchannel
    at TChannel.send [as request] (/home/uber/autobahn/node_modules/tchannel/index.js:286:15)
    at TChannel.send (/home/uber/autobahn/node_modules/tchannel/index.js:278:20)
    at sendOrLocalPlain (/home/uber/autobahn/core/forward/index.js:83:18)
    at ForwardNode.forwardRequest (/home/uber/autobahn/core/forward/index.js:36:5)
    at onArg2 (/home/uber/autobahn/endpoints/forward.js:109:21)
    at SafeParseCallback (/home/uber/autobahn/node_modules/safe-json-parse/callback.js:17:5)
    at forward (/home/uber/autobahn/endpoints/forward.js:75:9)
    at TChannelServerOp.tchannelEndpoint [as handler] (/home/uber/autobahn/server/lib/tchannel-raw-handler.js:14:9)
    at runHandler (/home/uber/autobahn/node_modules/tchannel/index.js:764:14)
    at process._tickDomainCallback (node.js:459:13)

@Raynos Raynos added the node label Jun 16, 2015
@Raynos
Copy link
Contributor Author

Raynos commented Jun 16, 2015

It's a known issue that channel.close() is not graceful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant