Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoexecute of BinDiff hangs and manual import applys too many diffs on first attempt #30

Open
Aaron-1234 opened this issue Dec 18, 2024 · 1 comment

Comments

@Aaron-1234
Copy link

Windows 11
Ghidra ver. 11.0.3 and 11.1.2 with Java 21.0.4
BinDiff ver. 8
BinExport 12 (Updated for Ghidra 11.0.3)
BinDiffHelper v.0.6.1

When attempting to "Diff with other file from ghidra project"
The process shows binexport running for each ghidra project and then hangs on "Executing BinDiff" at status bar of 40% (2 of 5)
The only way to close out is to kill the process in Task Manager. The 'X' button on the progress bar does not kill the extension.

I tested this on Ghidra 11.0.3 as well since the current latest binexport seems to be supported for that version, but I get the same result. BinDiff is installed in the default location C:\Program Files\BinDiff and I pointed to the BinDiff binary here: C:\Program Files\BinDiff\bin\bindiff.exe

When "Use externally created .BinDiff file"
I can export from ghidra using binexport manually, load them into BinDiff, and then access that .BinDiff file from BinDiffHelper and load the database fine and see the diffs and apply them. However, there does seem to be a bug here as well as. When a fresh database is loaded and I select only one check box (does not seem to matter which one) and then select "import checked functions' names" it will import a large set (not all, but most) diffs in the list. When I CTRL+Z to undo that and then select one again it will apply only that one. If on a fresh load of the data base, I select 2 or more check boxes and again press "import checked functions' names" it will only import the checked boxes as one would expect.

@ubfx
Copy link
Owner

ubfx commented Dec 19, 2024

Thank you for the report.

When a fresh database is loaded and I select only one check box (does not seem to matter which one) and then select "import checked functions' names" it will import a large set (not all, but most) diffs in the list.

I will try to reproduce and fix this.
Regarding the "Executing BinDiff" problem, I will have to add some more logging around that place because I have no idea what that could be caused by. Maybe some antivirus/firewall blocking the execution of a new process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants